[FLINK-37306][tests] Fix MySQLSourceITCase failure in non-UTC timezone#3917
Merged
leonardBang merged 1 commit intoapache:masterfrom Feb 18, 2025
Merged
Conversation
yuxiqian
force-pushed
the
hotfix/mysql-ci-error-in-non-utc-timezone
branch
from
9da5114 to
79e601d
Compare
yuxiqian
force-pushed
the
hotfix/mysql-ci-error-in-non-utc-timezone
branch
from
79e601d to
d6c09a6
Compare
Member
Author
|
@leonardBang @lvyanquan PTAL |
Contributor
|
https://issues.apache.org/jira/browse/FLINK-37306 Could you link to this ticket ? |
yuxiqian
changed the title
SML0127
pushed a commit
to SML0127/flink-cdc-connectors
that referenced
this pull request
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes FLINK-37306.
The failing test cases were introduced in #3298 and #3876 (and more), but has not been exposed until we decided to run CI test cases in random timezones (#3650).
MySQLSourceITCase#testSourceMetricsMySQL docker container runs in UTC timezone by default, but
MySQLSourceITCase#testSourceMetricsdidn't specifyserverTimeZoneoption explicitly like other test cases. As a result, running test cases in non-UTC timezone will fail with the following error:MySqlTimezoneITCase,MysqlDebeziumTimeConverterITCase, andSpecificStartingOffsetITCaseThese cases need to run MySQL container in specific timezones, so they all have a method called
buildMySqlConfigWithTimezoneto create MySQL container with the same timezone as JVM.However, JVM timezone (fetched via
ZoneId.systemDefault()) returns UTC-offset timezone inGMT+04:30format, while MySQL configuration file requires it in+04:30format. This would block the container from starting up.MySqlMultipleTablesRenamingITCaseThis test case uses the same time-zone initialization code as
MySqlTimezoneITCase. Removed these codes and stick to UTC considering this case is not time-zone sensitive.